Re: [Xen-devel] [PATCH v3 17/47] xen/sched: make credit2 scheduler vcpu agnostic.

[Jürgen Groß <jgross@xxxxxxxx>]

On 25.09.19 17:02, Dario Faggioli wrote:
> On Sat, 2019-09-14 at 10:52 +0200, Juergen Gross wrote:
> > Switch credit2 scheduler completely from vcpu to sched_unit usage.
> >
> > As we are touching lots of lines remove some white space at the end
> > of
> > the line, too.
> >
> > Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> Reviewed-by: Dario Faggioli <dfaggioli@xxxxxxxx>
>
> I did spot another 'item' that wants to be turned into...
>
> > diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c
> > index a6083289f6..0d1ba97dbc 100644
> > --- a/xen/common/sched_credit2.c
> > +++ b/xen/common/sched_credit2.c
> >   
> > @@ -510,20 +510,20 @@ struct csched2_pcpu {
> >   };
> >   
> >   /*
> > - * Virtual CPU
> > + * Schedule Item
> >    */
> ... 'unit'.  :-)
Yes, that was the test whether the review is done thoroughly. ;-)

Thanks!


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel