[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 37/47] xen/sched: move per-cpu variable scheduler to struct sched_resource

On Wed, 2019-09-25 at 15:13 +0200, Jürgen Groß wrote:
> On 24.09.19 14:16, Jan Beulich wrote:
> > 
> > While at the first glance "sd" is used twice here, this 2nd use is
> > actually unnecessary - "cpu" hasn't changed from the beginning of
> > the function afaics, and hence "ops" could be used here.
> "sd" is now "sr" everywhere.
> And yes, using ops here seems okay.
> > Preferably with the suggested adjustments (but final judgement is
> > with the scheduler maintainers anyway)
> > Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Dario Faggioli <dfaggioli@xxxxxxxx>

(With sd->sr and with using ops.)

Dario Faggioli, Ph.D
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

Attachment: signature.asc
Description: This is a digitally signed message part

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.