[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v1 1/6] docs: add feature document for Xen hypervisor sysfs-like support

On 27.09.19 15:37, Ian Jackson wrote:
Jürgen Groß writes ("Re: [PATCH v1 1/6] docs: add feature document for Xen 
hypervisor sysfs-like support"):
On 27.09.19 12:37, Ian Jackson wrote:
I guess that keys will be chosen from some limited safe character
set ?  What about values ?  Might we create a key whose value contains
binary data ?

I'd go with "[-A-Za-z0-9@_.:()\[\]#,;]*" for keys

I think this is ASCII printing characters with the exception of
   ! " ` $ % ^ & * = + { } ' ~ < > / \ |

I struggle to find a principled explanation for this particular
exclusion set (apart from /), considering that following are
   - @ _ . : ( ) [ ] # , ;

Could we borrow some existing permitted character set ?  If we are
permitting shell metacharacters why not just permit all printable
ASCII except / ?

Hmm, maybe we should allow just the "Posix portable file name character
set"? That would be [-._0-9A-Za-z]. And we should explicitly not allow
the key names "." and "..".

and ASCII for values.

Do you mean "any 7-bit byte", or octet values 32-126 (0x20-0x7e)
inclusive, or something else ?


As I'd like to support e.g. the .config file contents of the hypervisor
build I guess I need (0x01-0xff) inclusive, right?

Would it be possible to add a script to xen.git which lists the
xenhypfs and checks that all the paths are documented ?  We could add
a few calls to that to osstest...

I'd expect some parts to be described rather generically (as can be seen
in patch 6 for the runtime parameters). Maybe I should add the entries
with wildcards there.

That would be nice.

Okay, will do.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.