Re: [Xen-devel] [PATCH for-4.13 1/2] xen/arm: domain_build: Avoid implicit conversion from ULL to UL

[Jürgen Groß <jgross@xxxxxxxx>]

On 29.09.19 17:56, Julien Grall wrote:
> Clang 8.0 will fail to build domain_build.c on Arm32 because of the
> following error:
>
> domain_build.c:448:21: error: implicit conversion from 'unsigned long long' to 
> 'unsigned long' changes value from 1090921693184 to 0
> [-Werror,-Wconstant-conversion]
>      bank_size = MIN(GUEST_RAM1_SIZE, kinfo->unassigned_mem);
>
> Arm32 is able to support more than 4GB of physical memory, so it would
> be theorically possible to create domian with more the 4GB of RAM.
> Therefore, the size of a bank may not fit in 32-bit.
>
> This can be resolved by switch the variable bank_size and the parameter
> tot_size to "paddr_t".
>
> Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
Release-acked-by: Juergen Gross <jgross@xxxxxxxx>


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel