[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v5 02/19] xen/sched: introduce unit_runnable_state()
- To: Juergen Gross <JGross@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Dario Faggioli <dfaggioli@xxxxxxxx>
- Date: Mon, 30 Sep 2019 07:22:15 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hBfBg1B/qWZaW/y1kTEdDQ2mPGubhHxrrBRE4up3MPw=; b=ezd5Bdd6+zcBadrLnAm+JgRyPIeQ66jTz6zVYkT5vZ3OIKzRIPvwmtT4BjqqK6WpmMLpBusi7VubltSnLWTOqERHVSd+aFft61g1V2j+NRCZXFgRqpKlf3YWQOu/oR5CzuanfGpuO3y9uPqlO/KpkH8EeIo1PoWOigIpGRzCQGFkAHy/xqPZrBkYZdmJv85pE8RkfuVwl4nk8hlabX9qM/eZH6MxGv6QrHMFnEb08el5da2ALQMIu6dgeCdHwC5LKzFeRQUr93K3no27BG97/n/6UasS7vnnxyTCo0woDT/4BCCtbE8AlMPtduu6YcP+lsSfRvni53luGW0pn+phHg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m2Kn22y3HHz2OLdnE30Iu+r1RACHTq0J2A8u0NE8EL3TKcRMr4lQ/gxx6whUF3KidQqq0m8Okd6z9Zn1BEc30B8NeG6KD+VzWzzbLxZJl32BCDRBfGaJmzGfHrap+BFiqMfuAwkJW7M/IRe5X3dAieGEQw7Ovb3IYSnK6MKiuxCKovqgYsmDjQx6k7g0i73jjcBX2jswXOF/V+aAdQDM7ShjVT+r4xZilwR/dSI7WoLxFcbanAdwgZaD94Cf6qHhv0AVDXWHLrqIXpTmRUI13jPhyI0Bg0aCDZWR17M6ZWVlMPWpa6zFXZo5G1t8Qu7bZCNyjW4TliRiYeQ0kK2ZtA==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=dfaggioli@xxxxxxxx;
- Cc: "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "wl@xxxxxxx" <wl@xxxxxxx>, "konrad.wilk@xxxxxxxxxx" <konrad.wilk@xxxxxxxxxx>, "George.Dunlap@xxxxxxxxxxxxx" <George.Dunlap@xxxxxxxxxxxxx>, "tim@xxxxxxx" <tim@xxxxxxx>, "ian.jackson@xxxxxxxxxxxxx" <ian.jackson@xxxxxxxxxxxxx>, "robert.vanvossen@xxxxxxxxxxxxxxx" <robert.vanvossen@xxxxxxxxxxxxxxx>, "julien.grall@xxxxxxx" <julien.grall@xxxxxxx>, "josh.whitehead@xxxxxxxxxxxxxxx" <josh.whitehead@xxxxxxxxxxxxxxx>, "mengxu@xxxxxxxxxxxxx" <mengxu@xxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>
- Delivery-date: Mon, 30 Sep 2019 07:24:24 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVd070RdX8FPw9T06Hz9NODDKgC6dD0PGA
- Thread-topic: [Xen-devel] [PATCH v5 02/19] xen/sched: introduce unit_runnable_state()
On Mon, 2019-09-30 at 07:21 +0200, Juergen Gross wrote:
> Today the vcpu runstate of a new scheduled vcpu is always set to
> "running" even if at that time vcpu_runnable() is already returning
> false due to a race (e.g. with pausing the vcpu).
>
> With core scheduling this can no longer work as not all vcpus of a
> schedule unit have to be "running" when being scheduled. So the
> vcpu's
> new runstate has to be selected at the same time as the runnability
> of
> the related schedule unit is probed.
>
> For this purpose introduce a new helper unit_runnable_state() which
> will save the new runstate of all tested vcpus in a new field of the
> vcpu struct.
>
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> ---
> RFC V2:
> - new patch
> V3:
> - add vcpu loop to unit_runnable_state() right now instead of doing
> so in next patch (Jan Beulich, Dario Faggioli)
> - make new_state unsigned int (Jan Beulich)
> V4:
> - add comment explaining unit_runnable_state() (Jan Beulich)
>
Reviewed-by: Dario Faggioli <dfaggioli@xxxxxxxx>
Regards
--
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)
Attachment:
signature.asc
Description: This is a digitally signed message part
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
