Re: [Xen-devel] [PATCH v4 02/12] livepatch: Allow to override inter-modules buildid dependency

[Jan Beulich <jbeulich@xxxxxxxx>]

On 28.09.2019 17:12, Pawel Wieczorkiewicz wrote:
> --- a/xen/include/public/sysctl.h
> +++ b/xen/include/public/sysctl.h
> @@ -35,7 +35,7 @@
>  #include "domctl.h"
>  #include "physdev.h"
>  
> -#define XEN_SYSCTL_INTERFACE_VERSION 0x00000012
> +#define XEN_SYSCTL_INTERFACE_VERSION 0x00000013

Oh, I see.

> @@ -956,6 +956,15 @@ struct xen_sysctl_livepatch_action {
>                                              /* hypervisor default. */
>                                              /* Or upper bound of time (ns) */
>                                              /* for operation to take. */
> +
> +/*
> + * Overwrite default inter-module buildid dependency chain enforcement.
> + * Check only if module is built for given hypervisor by comparing buildid.
> + */
> +#define LIVEPATCH_ACTION_APPLY_NODEPS (1 << 0)
> +    uint64_t flags;                         /* IN: action flags. */
> +                                            /* Provide additional parameters 
> */
> +                                            /* for an action. */

64 bits seems quite a lot (and unusual) for a flags field. Also,
as a nit, do you perhaps mean "override" instead of "overwrite"
in the comment?

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel