Re: [Xen-devel] [PATCH] xen/typesafe: Force helpers to be always_inline

[Jan Beulich <jbeulich@xxxxxxxx>]

On 30.09.2019 21:16, Andrew Cooper wrote:
> Clang in particular has a habit of out-of-lining these and creating multiple
> local copies of _mfn() and mfn_x(), etc.  Override this behaviour.

Is special casing the typesafe helpers then the right approach? The
fundamental idea after all is to let the compiler decide. I certainly
agree that not inlining such trivial functions despite the inline
keyword looks far from optimal, but if there's such a general issue
with clang, shouldn't we make "inline" expand to "always_inline"
uniformly?

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel