[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v6 5/8] xen/arm: assign devices to boot domains



Hi Stefano,

On 30/09/2019 22:12, Stefano Stabellini wrote:
On Sun, 29 Sep 2019, Julien Grall wrote:
On 9/27/19 12:11 AM, Stefano Stabellini wrote:
+        return 0;
+    }
+    /*
+     * xen,path specifies the corresponding node in the host DT.
+     * Both interrupt mappings and IOMMU settings are based on it,
+     * as they are done based on the corresponding host DT node.
+     */
+    else if ( dt_prop_cmp("xen,path", name) == 0 )
+    {
+        node = dt_find_node_by_path(prop->data);
+        if ( node == NULL )
+        {
+            printk(XENLOG_ERR "Couldn't find node %s in host_dt!\n",
+                   (char *)prop->data);
+            return -EINVAL;
+        }
+
+        res = iommu_assign_dt_device(kinfo->d, node);
+        if ( res < 0 )
+            return res; > +
+        res = handle_device_interrupts(kinfo->d, node, true);
+        if ( res < 0 )
+            return res;

Same here.

You are talking about return values, right? Not code style to be fixed
-- I cannot see anything wrong with the code style.

I honestly can't remember why I wrote "same here". Please ignore this one and I will have a look at the next version.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.