Re: [Xen-devel] [PATCH for-4.13] xen/arm: Add Skeleton for using configuring early printk using Kconfig

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

On 10/1/19 7:30 PM, Stefano Stabellini wrote:
> On Mon, 16 Sep 2019, Wei Liu wrote:
> > On Fri, Sep 13, 2019 at 11:39:53AM +0100, Julien Grall wrote:
> > > At the moment, early printk can only be configured on the make command
> > > line. It is not very handy because a user has to remove the option
> > > everytime it is using another command other than compiling the
> > > hypervisor.
> > >
> > > Furthermore, early printk is one of the few odds one that are not using
> > > Kconfig.
> > >
> > > So this is about time to move it to Kconfig. For now, a skeleton is
> > > added with one example based on Cadence UART. Follow-up will continue to
> > > convert all the options to Kconfig.
> > >
> > > Because Kconfig will prefix all the config by CONFIG_, it is necessary
> > > to adapt the define within the code.
> > >
> > > Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
> > >
> > > ---
> > >
> > > I have sent it as RFC because this is not complete. I will convert the
> > > rest once we agree the approach is correct.
> > Having a top-level Kconfig.debug and includes arch specific rules is how
> > Linux does it (albeit with different directory structure), so I think
> > we're just following the norm here. No objection from me.
> I agree
I know this is an RFC, but do you any opinion on the rest of the patch? 
Is the interface with the user good for you?
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel