Re: [Xen-devel] [PATCH-for-4.13 v2 0/2] libxl: fix assertion failure

[Paul Durrant <pdurrant@xxxxxxxxx>]

On Wed, 2 Oct 2019 at 17:04, Ian Jackson <ian.jackson@xxxxxxxxxx> wrote:
>
> Paul Durrant writes ("[PATCH-for-4.13 v2 0/2] libxl: fix assertion failure"):
> > This was originally a single patch, which is now patch #2 of this series.
> >
> > Paul Durrant (2):
> >   libxl: replace 'enabled' with 'unknown' in libxl_passthrough
> >     enumeration
> >   libxl: choose an appropriate default for passthrough...
>
> Thanks.  I have applied these, and also a style fixup (below).
>

Cool.

> I am continuing to look at the defaulting and config management here
> with a view to getting rid of some of the duplicated code and moving
> it all into libxl.
>

That would indeed be beneficial for the likes of libvirt. Perhaps it
would be reasonable to unify the create and build info at a libxl
level (even though they may feed into distinct domctls underneath for
the moment)?

  Cheers,

    Paul

> Ian.
>
> From b01b1dc046da70a2621a4d1f032ddb22b0cdde6b Mon Sep 17 00:00:00 2001
> From: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Date: Wed, 2 Oct 2019 16:55:47 +0100
> Subject: [PATCH] libxl: create: style: Add a pair of missing { ]
>
> From CODING_STYLE:
>
>   Every indented statement is braced, but blocks that contain just one
>   statement may have the braces omitted.  To avoid confusion, either all
>   the blocks in an if...else chain have braces, or none of them do.
>
> CC: Paul Durrant <paul.durrant@xxxxxxxxxx>
> Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> ---
>  tools/libxl/libxl_create.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
> index 62e13f3e7c..099761a2d7 100644
> --- a/tools/libxl/libxl_create.c
> +++ b/tools/libxl/libxl_create.c
> @@ -68,8 +68,9 @@ int libxl__domain_create_info_setdefault(libxl__gc *gc,
>          c_info->passthrough = ((c_info->type == LIBXL_DOMAIN_TYPE_PV) ||
>                                 !info.cap_iommu_hap_pt_share) ?
>              LIBXL_PASSTHROUGH_SYNC_PT : LIBXL_PASSTHROUGH_SHARE_PT;
> -    } else if (!info.cap_hvm_directio)
> +    } else if (!info.cap_hvm_directio) {
>          c_info->passthrough = LIBXL_PASSTHROUGH_DISABLED;
> +    }
>
>      /* An explicit setting should now have been chosen */
>      assert(c_info->passthrough != LIBXL_PASSTHROUGH_UNKNOWN);
> --
> 2.11.0
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel