Re: [Xen-devel] [PATCH v7b 5/8] xen/arm: assign devices to boot domains

[Julien Grall <julien.grall@xxxxxxx>]

Hi Stefano,

On 02/10/2019 23:43, Stefano Stabellini wrote:
> On Wed, 2 Oct 2019, Julien Grall wrote:
> > > +        if ( !found )
> > > +        {
> > > +            res = fdt_property(fdt, name, prop->data,
> > > fdt32_to_cpu(prop->len));
> > > +            if ( res )
> > > +                return res;
> > > +        }
> > > +    }
> > > +
> > > +    /*
> > > +     * Only handle passthrough properties if both xen,reg and xen,path
> > > +     * are present, or if xen,force-assign-without-iommu is specified.
> > > +     */
> > > +    if ( xen_reg != NULL && (xen_path != NULL || xen_force) )
> > > +    {
> > > +        res = handle_passthrough_prop(kinfo, xen_reg, xen_path, xen_force,
> > > +                                      address_cells, size_cells);
> > > +        if ( res < 0 )
> > >                return res;
> > >        }
> > I would print an error so the user knows what happen here.
> All right, I'll add:
>
>    printk(XENLOG_ERR "Failed to assign device to %pd\n", kinfo->d);
>
> More specific information about the type of failure is already printed
> by handle_passthrough_prop.
I am less concerned about the error when handle_passthrough_prop. What I am 
concerned about if the fact you will ignore xen,path if xen,reg is not present.
We should at least warn the user if not returning an error.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel