[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/2] efi/boot: fix set_color function


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>
  • Date: Fri, 4 Oct 2019 11:54:51 +0100
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=igor.druzhinin@xxxxxxxxxx; spf=Pass smtp.mailfrom=igor.druzhinin@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Fri, 04 Oct 2019 10:55:06 +0000
  • Ironport-sdr: ZFBojU95zSdDwxvkBNK2yQ6nMP58XOWjLzg7BTN6YnwIu/j1Rlsb03o+/rQd7inob/0WSMYg94 AFGXM/0si2qfc0h8tXVRewsJx63lIcdRjesAgnxtno0X1yHlyHR5xveVM2UoSn6SK1fqNFxNAp NpjI+8mYkAAAvZ5A/oPWzo+/A3AChNIa0XXHjJt4I/eKLltJH37ErESXQgu8mi/Cktvk+TvmFG Bcc6FXaLF61Ibfg1brIx1tSdBi62fx+HNvxQhpkoMnQNU1wvkenl3xJjLkQgQxdT4dDappQqYR fxg=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 04/10/2019 11:34, Jan Beulich wrote:
> On 03.10.2019 15:49, Igor Druzhinin wrote:
>> - 0 is a possible and allowed value for a color mask accroding to
>>   UEFI Spec 2.6 (11.9) especially for reserved mask
> 
> Hmm, looking at 2.8 (where it's section 12.9, which in turn is why
> section titles would be more helpful in such references) I can't
> see the case being mentioned explicitly. I can accept that
> ReservedMask might be zero, but then I'd prefer to handle that
> case in the caller, rather than allowing zero also for the three
> colors.

"If a bit is set in RedMask, GreenMask, or BlueMask then those bits of
the pixel represent the corresponding color." - "If a bit is set..."
implies it might not be set. Nothing prevents mask for the colors be 0
as well.

Igor

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.