Re: [Xen-devel] [PATCH] pci: clear host_maskall field on assign

[Jan Beulich <jbeulich@xxxxxxxx>]

On 08.10.2019 15:14, Roger Pau Monné  wrote:
> On Tue, Oct 08, 2019 at 01:28:49PM +0200, Jan Beulich wrote:
>> On 08.10.2019 13:09, Roger Pau Monné  wrote:
>>> Given that as you correctly point out maskall is unset after device
>>> reset, I feel that option 4 is the best one since it matches the state
>>> of the hardware after reset.
>>
>> Right, that's the variant coming closest to what hardware state
>> ought to be at that point. We'd need to double check that the
>> per-entry mask bits are all set at that point.
> 
> I'm not saying such check is not worth doing, but why do it in this
> case but not when also clearing the maskall (in msix_capability_init)
> when called from prepare_msix?

By "double check" I meant inspect the source, not to add checking logic.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel