Re: [Xen-devel] [PATCH for-4.13] xen/xsm: flask: Prevent NULL deference in flask_assign_{, dt}device()

[Julien Grall <julien.grall@xxxxxxx>]

On 09/10/2019 12:57, Artem Mygaiev wrote:
> Hi Julien
Hi,

> On Fri, 2019-10-04 at 17:42 +0100, Julien Grall wrote:
> > flask_assign_{, dt}device() may be used to check whether you can test
> > if
> > a device is assigned. In this case, the domain will be NULL.
> >
> > However, flask_iommu_resource_use_perm() will be called and may end
> > up
> > to deference a NULL pointer. This can be prevented by moving the call
> > after we check the validity for the domain pointer.
> >
> > Coverity-ID: 1486741
> The correct CID is 1486742
Hmmm yes. The coverity report e-mail is a bit confusing to read.

However, I have already committed the patch so we will have to leave with it :(.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel