Re: [Xen-devel] [XEN PATCH for-4.13 v3 10/10] libxl/xl: Overhaul passthrough setting logic

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Anthony PERARD writes ("Re: [Xen-devel] [XEN PATCH for-4.13 v3 10/10] libxl/xl: 
Overhaul passthrough setting logic"):
> On Fri, Oct 11, 2019 at 05:55:49PM +0100, Ian Jackson wrote:
> > LIBXL_PASSTHROUGH_UNKNOWN (aka "ENABLED" in an earlier uncommitted
> 
> I guess that's now LIBXL_PASSTHROUGH_UNSPECIFIED.

Heh, see my other mail, just crossed with yours.

> > +int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc,
> > +                                            uint32_t domid,
> > +                                            libxl_domain_config *d_config,
> > +                                            const libxl_physinfo *physinfo)
> > +{
> 
> [...]
> 
> > +}
> > +                                        
> 
> There are 40 trailing white space here, any reason? :-).

No.  I will get rid of them.  My editor doesn't complain about them
and my personal view is that this is pointless bureaucracy but it's
not just up to me, so I'll fix it.

> Beside a few typos, the patch looks fine to me:
> Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Thanks.

If I change "unspecified" back to "unknown", and fix the spaces (and
I'll have a look for typos), should I retain your ack ?

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel