[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH RFC for-4.13 07/10] xen/arm: Allow insn.h to be called from assembly



Hi Stefano,

On 10/1/19 10:00 PM, Stefano Stabellini wrote:
On Thu, 26 Sep 2019, Julien Grall wrote:
A follow-up patch will require to include insn.h from assembly code. So
wee need to protect any C-specific definition to avoid compilation
   ^ we                               ^ definitions

error when used in assembly code.
   ^ errors



Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
---
  xen/include/asm-arm/insn.h | 8 ++++++++
  1 file changed, 8 insertions(+)

diff --git a/xen/include/asm-arm/insn.h b/xen/include/asm-arm/insn.h
index 19277212e1..00391f83f9 100644
--- a/xen/include/asm-arm/insn.h
+++ b/xen/include/asm-arm/insn.h
@@ -1,8 +1,14 @@
  #ifndef __ARCH_ARM_INSN
  #define __ARCH_ARM_INSN
+#ifndef __ASSEMBLY__
+
  #include <xen/types.h>
+/*
+ * At the moment, arch-specific headers contain only definition for C
+ * code.
+ */

Please remove "At the moment, " because in-code comment should always
reflect the latest state of the codebase.

Well, we do have a lot of "Currently"/"At the moment"/"For now" in the code. Some of my patches went in recently with such wording, so why this particular one is a problem?

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.