Re: [Xen-devel] [XEN PATCH for-4.13 v7 04/11] libxl: libxl_domain_need_memory: Make it take a domain_config

[Jürgen Groß <jgross@xxxxxxxx>]

On 23.10.19 15:00, Ian Jackson wrote:
> This should calculate the extra memory needed for shadow and iommu,
> the defaults for which depend on values in c_info.  So we need this to
> have the complete domain config available.
>
> And the defaults should actually be updated and stored.  So make it
> non-const.
>
> We provide the usual kind of compatibility function for callers
> expecting 4.12 and earlier.  This function becomes responsible for the
> clone-and-modify of the b_info.
>
> No overall functional change for external libxl callers which use the
> API version system to request a particular API version.
>
> Other external libxl callers will need to update their calling code,
> and will then find that the new version of this function fills in most
> of the defaults in d_config.  Because libxl__domain_config_setdefault
> doesn't quite do all of the defaults, that's only partial.  For
> present purposes that doesn't matter because none of the missing
> settings are used by the memory calculations.  It does mean we need to
> document in the API spec that the defaulting is only partial.
>
> This lack of functional change is despite the fact that
> numa_place_domain now no longer calls
> libxl__domain_build_info_setdefault (via libxl_domain_need_memory).
> That is OK because it's idempotent and numa_place_domain's one call
> site is libxl__build_pre which is called from libxl__domain_build
> which is called from domcreate_bootloader_done, well after the
> defaults are set by initiate_domain_create.
>
> Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Release-acked-by: Juergen Gross <jgross@xxxxxxxx>


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel