Re: [Xen-devel] [XEN PATCH for-4.13 v7 11/11] libxl: On ARM, reject future new passthrough modes too

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Wed, Oct 23, 2019 at 02:00:13PM +0100, Ian Jackson wrote:
> This is most pleasantly done by also changing the if to a switch.
> 
> Suggested-by: Julien Grall <julien@xxxxxxx>
> CC: Julien Grall <julien@xxxxxxx>
> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> 
> ---
> v7: New patch in this version of the series.
> ---
>  tools/libxl/libxl_arm.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/libxl/libxl_arm.c b/tools/libxl/libxl_arm.c
> index 2f1ca69431..0b3025a9ed 100644
> --- a/tools/libxl/libxl_arm.c
> +++ b/tools/libxl/libxl_arm.c
> @@ -1203,9 +1203,15 @@ int libxl__arch_passthrough_mode_setdefault(libxl__gc 
> *gc,
>          c_info->passthrough = LIBXL_PASSTHROUGH_SHARE_PT;
>      }
>  
> -    if (c_info->passthrough == LIBXL_PASSTHROUGH_SYNC_PT) {
> +    switch (c_info->passthrough) {
> +    case LIBXL_PASSTHROUGH_DISABLED;

That looks strange, there a semicolon ^ here instead of a colon ':'.

> +    case LIBXL_PASSTHROUGH_SHARE_PT:
> +        break;
> +
> +    default:
>          LOGD(ERROR, domid,
> -             "passthrough=\"sync_pt\" not supported on ARM\n");
> +             "passthrough=\"%s\" not supported on ARM\n",
> +             libxl__passthrough_mode_to_string(c_info->passthrough);

I can't find where this function is defined. Does it exist?
You probably want libxl_passthrough_to_string().
Also there's a missing ) to terminate LOGD list of args.

I think that's it. With those 3 things fixed:
Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Cheers,

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel