[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH] tools/ocaml: Fix build error with Arch Linux
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Petre Ovidiu PIRCALABU <ppircalabu@xxxxxxxxxxxxxxx>
- Date: Mon, 28 Oct 2019 16:35:17 +0000
- Accept-language: ro-RO, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bitdefender.com; dmarc=pass action=none header.from=bitdefender.com; dkim=pass header.d=bitdefender.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BpGv6mdGvdk0+IueRr32B/WG6xG5rDXytQQusiUZwWc=; b=dSR7Fao2DlGiGQGEXyjZGJFOLeAkcknq9ZPnG6D4Ap6l7MetcSrc/DTMI6DtLMajNcDVONYSiDYfsr6yMJRZLUMHNgDou6XE/RWxZ4itAunqEYGqCh41jSMUWCcYoo/wqqxW//SGiqBigKsxyIIH9HZqWCg1hbNQca+paLZMZMcGisWSECVg5x1HueXMImCfLv5NSR/Ln2qtbt6N27Q6ZrHFCVI6iiY/yiEnmsnfwUc4deJQp1RJLl2hGwkAOkdV8NNCVPQ4e4l40vTXiI7ZuUOaePiq8HTWP+erd8LGfbQUJXy+a4V6oJ5iV0qRold19vRKhtfX87pag/1z8NkLmQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gbLjkKVqdgFKzjJBX+oFXmxzqLndwNNw5EHMnAVqRf1P/+yz/YjtmDtglSNYTnDROEQ4PZioXqpX0llqpQil6pNlM43mEkkq0k4CKt4PCY7D8l7UUPpssuSpGp0RbBNdO++DeNCrKOMgAJTNBpCFs9yZeHiArYmdO4PLP0xGpTr3MC0cSOmtuBtSJxIwTc83PmCq5RQg/XeNfCQMi0Sj0xoGwGfz+WxoqsycQidUkB3pbIOfq4+aeDh+uy1vrtsJPEoWl1DYyqE6Nuw9MqewdR7KkWZe2gqYQ+YZG1msIWaJK+VKFg72P2I8usCQaVdVC9MikGfrnqlnXP1MePwldg==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=ppircalabu@xxxxxxxxxxxxxxx;
- Cc: Jürgen Groß <jgross@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 28 Oct 2019 16:35:35 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVi4r/yq+iTymeDUGBC/exKCe9UadwIiuAgAAiGYA=
- Thread-topic: [Xen-devel] [PATCH] tools/ocaml: Fix build error with Arch Linux
On Mon, 2019-10-28 at 14:33 +0000, Anthony PERARD wrote:
> On Sat, Oct 26, 2019 at 02:21:10AM +0300, Petre Pircalabu wrote:
> > gcc (GCC) 9.2.0 complains:
> >
> > xentoollog_stubs.c: In function ‘stub_xtl_ocaml_vmessage’:
> > xentoollog_stubs.c:93:16: error: initialization discards ‘const’
> > qualifier from pointer target type [-Werror=discarded-qualifiers]
> > 93 | value *func = caml_named_value(xtl->vmessage_cb) ;
> > | ^~~~~~~~~~~~~~~~
>
> Hi Petre,
>
> Thanks for the patch, it looks fine. However it would be nice to add
> some more context on why gcc complains. A quick search seems to lead
> to
>
https://github.com/ocaml/ocaml/commit/4f03a1467d29cf587df5a191830f1525506ee0e3
> "Make caml_named_value return a const value*"
> which change the prototype of caml_named_value.
>
> With the commit message changed:
> Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
>
> CC Jürgen, I think it would be nice to have the build fix in the
> release.
>
> Cheers.
>
Thank you very much for your input. I will modify the commit message
and send a v2 version of this patch.
Best regards,
Petre
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
