Re: [Xen-devel] [PATCH for-4.13 v2] passthrough: simplify locking and logging

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Mon, Nov 04, 2019 at 11:13:48AM +0000, Durrant, Paul wrote:
> > -----Original Message-----
> > From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > Sent: 04 November 2019 11:06
> > To: Durrant, Paul <pdurrant@xxxxxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx
> > Cc: Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>; jgross@xxxxxxxx;
> > jbeulich@xxxxxxxx
> > Subject: Re: [Xen-devel] [PATCH for-4.13 v2] passthrough: simplify locking
> > and logging
> > 
> > On 04/11/2019 08:31, Durrant, Paul wrote:
> > >> -----Original Message-----
> > >> From: Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>
> > >> Sent: 01 November 2019 19:28
> > >> To: xen-devel@xxxxxxxxxxxxxxxxxxxx
> > >> Cc: Durrant, Paul <pdurrant@xxxxxxxxxx>; jbeulich@xxxxxxxx;
> > >> jgross@xxxxxxxx
> > >> Subject: [PATCH for-4.13 v2] passthrough: simplify locking and logging
> > >>
> > >> From: Paul Durrant <pdurrant@xxxxxxxxxx>
> > >>
> > >>
> > >> Signed-off-by: Paul Durrant <pdurrant@xxxxxxxxxx>
> > >> ---
> > >>
> > >>
> > >> v2: updated Paul's email address
> > 
> > This was work you did at Citrix, yes?
> > 
> > > Reviewed-by: Paul Durrant <pdurrant@xxxxxxxxxx>
> > 
> > SoB and R-by?
> 
> I did do the work while I was at Citrix, but surely the SoB must be updated 
> since the patch is only now being posted?

I don't think it matters when a patch is publicly posted, the SoB
shouldn't change.
Also, Igor, I think you need to add your own SoB to the patch. This would
be because of (b) or (c) of the "Developer's Certificate of Origin 1.1" [1].

> As for the R-b, why should that be historic?

I think he meant that reviewing your own work is a bit weird. On the
other hand, it is possible to have both a SoB and a R-b from the same
persone, if the original patch has been modified.


[1]:
Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.


Cheers,

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel