[Xen-devel] [PATCH] create-diff-object: do not strip STN_UNDEF symbols from *.fixup

[Pawel Wieczorkiewicz <wipawel@xxxxxxxxx>]

The rela groups in the *.fixup sections vary in size. That makes it
more complex to handle in the livepatch_strip_undefined_elements().
It is also unnecessary as the .fixup sections are unlikely to have
any STN_UNDEF symbols anyway.

Signed-off-by: Pawel Wieczorkiewicz <wipawel@xxxxxxxxx>
---
 create-diff-object.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/create-diff-object.c b/create-diff-object.c
index 2f0e162..abf3cc7 100644
--- a/create-diff-object.c
+++ b/create-diff-object.c
@@ -2081,6 +2081,13 @@ static void livepatch_strip_undefined_elements(struct 
kpatch_elf *kelf)
                if (!is_rela_section(sec))
                        continue;
 
+               /* The rela groups in the .fixup sections vary in size.
+                * Ignore them as they are unlikely to have any STN_UNDEF
+                * symbols anyway.
+                */
+               if (strstr(sec->name, ".fixup"))
+                       continue;
+
                /* only known, fixed-size entries can be stripped */
                entry_size = get_section_entry_size(sec->base, kelf);
                if (entry_size == 0)
-- 
2.16.5




Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Ralf Herbrich
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel