Re: [Xen-devel] [PULL 0/4] Trivial branch patches

[no-reply@xxxxxxxxxxx]

Patchew URL: https://patchew.org/QEMU/20191105144247.10301-1-laurent@xxxxxxxxx/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PULL 0/4] Trivial branch patches
Type: series
Message-id: 20191105144247.10301-1-laurent@xxxxxxxxx

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
0102c79 global: Squash 'the the'
9c583b0 qom: Fix error message in object_class_property_add()
299eefd hw/misc/grlib_ahb_apb_pnp: Fix 8-bit accesses
c931231 hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to PnP registers

=== OUTPUT BEGIN ===
1/4 Checking commit c93123187df2 (hw/misc/grlib_ahb_apb_pnp: Avoid crash when 
writing to PnP registers)
2/4 Checking commit 299eefd37522 (hw/misc/grlib_ahb_apb_pnp: Fix 8-bit accesses)
3/4 Checking commit 9c583b04fdb1 (qom: Fix error message in 
object_class_property_add())
WARNING: line over 80 characters
#31: FILE: qom/object.c:1109:
+        error_setg(errp, "attempt to add duplicate property '%s' to object 
(type '%s')",

WARNING: line over 80 characters
#43: FILE: qom/object.c:1141:
+        error_setg(errp, "attempt to add duplicate property '%s' to class 
(type '%s')",

total: 0 errors, 2 warnings, 22 lines checked

Patch 3/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/4 Checking commit 0102c79a3068 (global: Squash 'the the')
ERROR: do not use C99 // comments
#26: FILE: disas/libvixl/vixl/invalset.h:105:
+  // Note that this does not mean the backing storage is empty: it can still

total: 1 errors, 0 warnings, 56 lines checked

Patch 4/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20191105144247.10301-1-laurent@xxxxxxxxx/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@xxxxxxxxxx
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel