[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v2 02/15] mm/mmu_notifier: add an interval tree notifier
- To: Jason Gunthorpe <jgg@xxxxxxxxxxxx>
- From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
- Date: Thu, 7 Nov 2019 22:33:02 -0800
- Cc: "nouveau@xxxxxxxxxxxxxxxxxxxxx" <nouveau@xxxxxxxxxxxxxxxxxxxxx>, "dri-devel@xxxxxxxxxxxxxxxxxxxxx" <dri-devel@xxxxxxxxxxxxxxxxxxxxx>, Michal Hocko <mhocko@xxxxxxxxxx>, "linux-mm@xxxxxxxxx" <linux-mm@xxxxxxxxx>, Andrea Arcangeli <aarcange@xxxxxxxxxx>, David Zhou <David1.Zhou@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>, "linux-rdma@xxxxxxxxxxxxxxx" <linux-rdma@xxxxxxxxxxxxxxx>, "amd-gfx@xxxxxxxxxxxxxxxxxxxxx" <amd-gfx@xxxxxxxxxxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Ben Skeggs <bskeggs@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ralph Campbell <rcampbell@xxxxxxxxxx>, John Hubbard <jhubbard@xxxxxxxxxx>, Jerome Glisse <jglisse@xxxxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Petr Cvek <petrcvekcz@xxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Mike Marciniszyn <mike.marciniszyn@xxxxxxxxx>, "Felix.Kuehling@xxxxxxx" <Felix.Kuehling@xxxxxxx>, Christian König <christian.koenig@xxxxxxx>, Alex Deucher <alexander.deucher@xxxxxxx>, Dennis Dalessandro <dennis.dalessandro@xxxxxxxxx>
- Delivery-date: Fri, 08 Nov 2019 06:33:55 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Nov 07, 2019 at 08:06:08PM +0000, Jason Gunthorpe wrote:
> >
> > enum mmu_range_notifier_event {
> > MMU_NOTIFY_RELEASE,
> > };
> >
> > ...assuming that we stay with "mmu_range_notifier" as a core name for this
> > whole thing.
> >
> > Also, it is best moved down to be next to the new MNR structs, so that all
> > the
> > MNR stuff is in one group.
>
> I agree with Jerome, this enum is part of the 'struct
> mmu_notifier_range' (ie the description of the invalidation) and it
> doesn't really matter that only these new notifiers can be called with
> this type, it is still part of the mmu_notifier_range.
>
> The comment already says it only applies to the mmu_range_notifier
> scheme..
In fact the enum is entirely unused. We might as well just kill it off
entirely.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
