Re: [Xen-devel] [PATCH v2] tools/hotpug: only attempt to call 'ip route' if there is valid command

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Thu, Nov 07, 2019 at 06:52:00PM +0000, Wei Liu wrote:
> On Thu, Nov 07, 2019 at 04:58:14PM +0000, paul@xxxxxxx wrote:
> > --- a/tools/hotplug/Linux/vif-route
> > +++ b/tools/hotplug/Linux/vif-route
> > @@ -22,12 +22,16 @@ dir=$(dirname "$0")
> >  main_ip=$(dom0_ip)
> >  
> >  case "${command}" in
> > +    add)
> > +        ;&
> >      online)
> >          ifconfig ${dev} ${main_ip} netmask 255.255.255.255 up
> 
> Hmm... I think we may need to replace ifconfig with ip because now
> distros (at least Debian and Arch) don't install ifconfig by default.

Arch Linux don't install Xen by default... so this script doesn't
exist... so it doesn't matter if ifconfig is available or not ...
It is fine to depends on 'ifconfig' when installing Xen.

Anyway, it might be a nice improvement to have one less dependency, but
it's not something that needs to be done right away.

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel