[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [OSSTEST PATCH 1/2] ts-libvirt-build: Provide PKG_CONFIG_PATH


  • To: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jim Fehlig <jfehlig@xxxxxxxx>
  • Date: Tue, 12 Nov 2019 15:40:41 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0gBVMxYTVHPwJ7hhWCClwJ0xWpjj03XcsLajFbCZ/TE=; b=StdfOEYMzEewNNCtYHRFaNNuU74LC95CzHanT2Oi8b+C5JzrgaIpd/DpmabiZNNeVv4XK77M6ubzaqKai2VUigZFpd58i+Ahcg0QHdtUl2ImVsPDh73m2uCkkIzJ4ECa43QluwRKBvj1w5n31QeZ5/m/SQcvQE8L5Jt3yH4uDoP9eZBPS6zHX41Gh3WkAVgdJfgG3JVNQiatcoY1cQ2NMAVtn75Pu/d4U99ILntXCX5Bv1l+Omf1J5gN4s/1P162w2iQqA74Lox/WMRJQhGCkF0+mSnNRsGxQWn98TSNFr34Yy0rOIevL8sgRwxBzPcpuHi/M+7JhUE49uFFEkT7CA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LNpgSiKKZp2L8ApBDJPW6kgfq41M77YRvN0hE5qcpuMfE/zrr+5HUcITgL2tZHT6hPHJ0sA7LrW6AunGRxqkafs0QbSn/LeggD29bwD9aSsnoihCyIwPeOYDf7yH7r3qM6+v2uSSV44w5UWR3M8XQJHIYx0MHflikWYdwcTI4G81WLZiDRksvq3YhwdNcuC9ltmHH/e/MGiADWRhqPkTXx4ChyfBCrQo0Bewq3XyTRKsDRe52Spw+qIlObV5TvRGBxJsuhdUTlSsrBuuTYoooT2MPsT5KDN3Di+QUXEr4pnTiT/vBIa+Bgpf7VcZAsipArZbKziWFJmW8b3Myh5uKA==
  • Authentication-results: spf=none (sender IP is ) smtp.mailfrom=jfehlig@xxxxxxxx;
  • Cc: Juergen Gross <JGross@xxxxxxxx>
  • Delivery-date: Tue, 12 Nov 2019 15:44:00 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHVmVI7cHFevYomN0alPs/WNgSR96eHrGyA
  • Thread-topic: [OSSTEST PATCH 1/2] ts-libvirt-build: Provide PKG_CONFIG_PATH

On 11/12/19 5:09 AM, Ian Jackson wrote:
> In osstest we do not install the xen tree in /usr/local because the
> build environment is shared with many different build jobs which might
> be using different versions of Xen.  We put it in a job-specific
> directory in ~osstest on the build host, and set environment variables
> to ensure that it all gets picked up.
> 
> Recent versions of libvirt insist on finding xenlight.pc; otherwise
> they disable libxl support.  So we must add a PKG_CONFIG_PATH setting.

Sorry. There was a hack to workaround a fedora 28 bug, but now that it is EOL 
the hack was removed

https://libvirt.org/git/?p=libvirt.git;a=commit;h=18981877d2e20390a79d068861a24e716f8ee422

> (In all cases, contrary to the usual protocol for path-like variables,
> we do not append but instead simply set the variable.  This is OK
> because this is an osstest build script run via ssh to the build host,
> so the variables won't have been set already.)
> 
> CC: Jim Fehlig <jfehlig@xxxxxxxx>
> Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> ---
>   ts-libvirt-build | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/ts-libvirt-build b/ts-libvirt-build
> index bc08190a..2a363f43 100755
> --- a/ts-libvirt-build
> +++ b/ts-libvirt-build
> @@ -60,6 +60,7 @@ sub config() {
>           cd libvirt
>           CFLAGS="-g -I$xenprefix/include/" \\
>           LDFLAGS="-g -L$xenprefix/lib/ -Wl,-rpath-link=$xenprefix/lib/" \\
> +        PKG_CONFIG_PATH="$xenprefix/lib/pkgconfig/" \\
>           GNULIB_SRCDIR=$builddir/libvirt/$gnulib->{Path} \\
>               ./autogen.sh --no-git \\
>                            --with-libxl --without-xen --without-xenapi 
> --without-selinux \\

Unrelated, but the legacy xen and xenapi drivers have been removed so the 
--without-{xen,xenapi} options could be dropped.

Regards,
Jim
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.