Re: [Xen-devel] [RFC 7/7] arm/gic-v3: add GIC version suffix to iomem range variables

[Julien Grall <julien.grall.oss@xxxxxxxxx>]

On Tue, 12 Nov 2019, 05:59 Stefano Stabellini, <sstabellini@xxxxxxxxxx> wrote:

On Wed, 6 Nov 2019, Andrii Anisov wrote:
> From: Andrii Anisov <andrii_anisov@xxxxxxxx>
>
> ARM Compiler 6.6 has a proven bug: static data symbols, moved to an init
> section, becomes global. Thus these symbols clash with ones defined in
> gic-v2.c. The straight forward way to resolve the issue is to add the GIC
> version suffix, at least for one of the conflicting side.
>
> Signed-off-by: Andrii Anisov <andrii_anisov@xxxxxxxx>

The patch is acceptable but this seems a very serious compiler bug.

I am a bit worried this is not going to prevent introducing any similar bug in the future. I think, we have a way to enforce uniq symbols (see CONFIG_UNIQUE_SYMBOLS). Would it work for you here?

This, together with the other bug described in the previous patch, makes
me think the ARMCC is not quite ready for showtime. Do you know if there
are any later version of the compiler that don't have these problems?

Related to this as this been reported to Arm?

Cheers,

-- 

Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel