Re: [Xen-devel] [RFC 6/7] arm: Introduce dummy empty functions for data only C files

[Andrii Anisov <andrii.anisov@xxxxxxxxx>]

Hello Stefano,

On 11.11.19 22:57, Stefano Stabellini wrote:
> Oh man, this is truly horrible.
I feel your pain.

> If we really have to do this please:
>
> - use the same dummy function name in all files
No, because

> - the function should be static
those functions will not handle the case if are static.

ARM commented the issue in the correspondent support case:

"A known workaround is to edit the source file and add an unused empty function, as 
you’ve already found. By default, an unused empty function should be removed from the final 
image by the unused section elimination feature of the linker, so it shouldn’t have a code 
size impact.

A command-line option workaround isn’t available. We’ll now set this case to a 
“Defect/Enhancement” state while the issue remains unfixed, and will keep you updated 
accordingly."


> - hiding the function within a #ifdef ARMCC block
> - potentially hide the whole horrible hack behind a #define so that it
>    would become at the call site:
>
>   +ARMCC_DUMMY_FUNC_HACK()
This is quite reasonable.

--
Sincerely,
Andrii Anisov.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel