Re: [Xen-devel] [PATCH for-4.13 v4 1/3] vmx: add ASSERT to prevent syncing PIR to IRR...

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Thu, Nov 14, 2019 at 01:25:54PM +0100, Jan Beulich wrote:
> On 13.11.2019 16:59, Roger Pau Monne wrote:
> > --- a/xen/arch/x86/hvm/vmx/vmx.c
> > +++ b/xen/arch/x86/hvm/vmx/vmx.c
> > @@ -2054,6 +2054,17 @@ static void vmx_sync_pir_to_irr(struct vcpu *v)
> >      unsigned int group, i;
> >      DECLARE_BITMAP(pending_intr, NR_VECTORS);
> >  
> > +    if ( v != current && v->is_running )
> 
> Iirc it was suggested to use vcpu_runnable() here. Is there a reason
> you used the less reliable (more prone to races) ->is_running?

My mistake, I don't think there's any reason to prefer is_running over
vcpu_runable in this case. I can resend with this fixed, but I will
wait for comments on the other patches.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel