[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v1 1/2] libxl: introduce new backend type VINPUT



Oleksandr Grytsov writes ("Re: [PATCH v1 1/2] libxl: introduce new backend type 
VINPUT"):
> On Fri, Nov 15, 2019 at 9:43 PM Ian Jackson <ian.jackson@xxxxxxxxxx> wrote:
> > Sorry for the delay replying.  In your earlier mails I had trouble
> > figuring out what you meant but this little vignette makes it clear to
> > me.
> >
> > I think the problem you are trying to solve is this: in your case
> > QEMU_BACKEND needs to depend on the visible vkb_backend field, but the
> > device->backend_kind is set unconditionally to just VKB ?
> 
> Exactly.

Thanks.

> > Could you solve this problem by inventing a new backend_kind, and
> > writing your own function libxl__device_from_vkb, and putting
> > *different* values into backend_kind ?  I think that is what
> > backend_kind is for.  See for example various console functions and
> > also libxl__device_from_disk.
> 
> This what was done in this patch. VINPUT backend type was introduced.

We have come full circle.  But on the way you have managed to get into
my thick head what is going on here.  Well done and thank you.

I will go back and do a more code review of the original patch.

> Probably the name should be changed but have no idea which backend
> kind is more suitable for this purpose.

I am happy this this name.  It is not in the public API so if it turns
out to be wrong we can change it.

> > AFAICT from the code it just uses what would the `usual' xenstore pv
> > control plane path for a device called "vkb" ?
> 
> I guess yes.
> 
> > So maybe we could call it "pv" ?
> 
> Do you mean LIBXL_VKB_BACKEND_PV?

I think so.  What do you think ?  I am just trying to get rid of the
string `linux' when it's not Linux specific.  I quickly scanned
kbdif.h and it looks very like a Xen PV protocol :-).  So "pv" would
sound good to me and better than "Linux", unless someone else has an
opinion.

CCing various maintainers who might have an opinion.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.