[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 00/12] Convert cpu_up/down to device_online/offline
- To: Qais Yousef <qais.yousef@xxxxxxx>
- From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
- Date: Mon, 18 Nov 2019 21:27:12 +0100 (CET)
- Cc: Mark Rutland <mark.rutland@xxxxxxx>, x86@xxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, "Rafael J. Wysocki" <rafael@xxxxxxxxxx>, "Peter Zijlstra \(Intel\)" <peterz@xxxxxxxxxxxxx>, Catalin Marinas <catalin.marinas@xxxxxxx>, Ram Pai <linuxram@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, "James E.J. Bottomley" <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, Richard Fontana <rfontana@xxxxxxxxxx>, Nadav Amit <namit@xxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, sparclinux@xxxxxxxxxxxxxxx, Will Deacon <will@xxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Davidlohr Bueso <dave@xxxxxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Helge Deller <deller@xxxxxx>, Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>, Eiichi Tsukata <devel@xxxxxxxxxxxx>, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Fenghua Yu <fenghua.yu@xxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, "Paul E. McKenney" <paulmck@xxxxxxxxxx>, Josh Triplett <josh@xxxxxxxxxxxxxxxx>, Nicholas Piggin <npiggin@xxxxxxxxx>, Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Josh Poimboeuf <jpoimboe@xxxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Pavankumar Kondeti <pkondeti@xxxxxxxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, Christophe Leroy <christophe.leroy@xxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>, linux-parisc@xxxxxxxxxxxxxxx, Steve Capper <steve.capper@xxxxxxx>, Jiri Kosina <jkosina@xxxxxxx>, linuxppc-dev@xxxxxxxxxxxxxxxx, Zhenzhong Duan <zhenzhong.duan@xxxxxxxxxx>, Armijn Hemel <armijn@xxxxxxxxxx>, James Morse <james.morse@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Paul Mackerras <paulus@xxxxxxxxx>, Enrico Weigelt <info@xxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Thiago Jung Bauermann <bauerman@xxxxxxxxxxxxx>
- Delivery-date: Mon, 18 Nov 2019 20:29:37 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, 18 Nov 2019, Qais Yousef wrote:
> I had to make an educated guess that you're probably the 'maintainer' of cpu
> hotplug - but there's no explicit entry that says that. Please let me know if
> I need to bring the attention of others too.
:)
> The series do have few rough edges to address, but it's relatively
> straightforward and I think does offer a nice improvement in the form of
> consolidating the API for bringing up/down cpus from external
> subsystems/drivers. Beside fix the inconsistency of device's core view of the
> state of the cpu which can happen when cpu_{up/down} are called directly.
>
> The downside I see is that the external API to bring cpus up/down for
> suspend/resume and at boot seem to have grown a bit organically (I've added
> a couple in this series to address 2 direct users of cpu_{up,down}). We might
> need to rethink this API, but I think this is outside the scope of this
> series.
>
> Any thoughts/feedback would be appreciated.
Let me have a look.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
