Re: [Xen-devel] [PATCH for-4.13] efi: do not use runtime services table with efi=no-rs

[Jürgen Groß <jgross@xxxxxxxx>]

On 17.11.19 00:47, Marek Marczykowski-Górecki wrote:
> Before dfcccc6631 "efi: use directmap to access runtime services table"
> all usages of efi_rs pointer were guarded by efi_rs_enter(), which
> implicitly refused to operate with efi=no-rs (by checking if
> efi_l4_pgtable is NULL - which is the case for efi=no-rs). The said
> commit (re)moved that call as unneeded for just reading content of
> efi_rs structure - to avoid unnecessary page tables switch. But it
> neglected to check if efi_rs access is legal.
>
> Fix this by adding explicit check for runtime service being enabled in
> the cases that do not use efi_rs_enter().
>
> Reported-by: Roman Shaposhnik <roman@xxxxxxxxxx>
> Fixes: dfcccc6631 "efi: use directmap to access runtime services table"
> Signed-off-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
Release-acked-by: Juergen Gross <jgross@xxxxxxxx>


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel