|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 1/2] x86/vtx: Fix fault semantics for early task switch failures
On 22.11.2019 13:37, Roger Pau Monné wrote: > On Thu, Nov 21, 2019 at 10:15:50PM +0000, Andrew Cooper wrote: >> The VT-x task switch handler adds inst_len to rip before calling >> hvm_task_switch(). This causes early faults to be delivered to the guest >> with >> trap semantics, and break restartibility. >> >> Instead, pass the instruction length into hvm_task_switch() and write it into >> the outgoing tss only, leaving rip in its original location. >> >> For now, pass 0 on the SVM side. This highlights a separate preexisting bug >> which will be addressed in the following patch. >> >> While adjusting call sites, drop the unnecessary uint16_t cast. >> >> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> > > Code LGTM: > > Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx> Acked-by: Jan Beulich <jbeulich@xxxxxxxx> _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
 |
Lists.xenproject.org is hosted with RackSpace, monitoring our |