Re: [Xen-devel] [PATCH] EFI: fix "efi=attr=" handling

[Wei Liu <wl@xxxxxxx>]

On Tue, Nov 26, 2019 at 09:25:27AM +0100, Jan Beulich wrote:
> Commit 633a40947321 ("docs: Improve documentation and parsing for efi=")
> failed to honor the strcmp()-like return value convention of
> cmdline_strcmp().
> 
> Reported-by: Roman Shaposhnik <roman@xxxxxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Wei Liu <wl@xxxxxxx>

> 
> --- a/xen/common/efi/boot.c
> +++ b/xen/common/efi/boot.c
> @@ -1430,9 +1430,9 @@ static int __init parse_efi_param(const
>          }
>          else if ( (ss - s) > 5 && !memcmp(s, "attr=", 5) )
>          {
> -            if ( cmdline_strcmp(s + 5, "uc") )
> +            if ( !cmdline_strcmp(s + 5, "uc") )
>                  efi_map_uc = true;
> -            else if ( cmdline_strcmp(s + 5, "no") )
> +            else if ( !cmdline_strcmp(s + 5, "no") )
>                  efi_map_uc = false;
>              else
>                  rc = -EINVAL;

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel