Re: [Xen-devel] [PATCH v2 6/7] livepatch-build: Strip transient or unneeded symbols

["Wieczorkiewicz, Pawel" <wipawel@xxxxxxxxx>]

> On 25. Nov 2019, at 15:38, Ross Lagerwall <ross.lagerwall@xxxxxxxxxx> wrote:
> 
> On 9/16/19 12:30 PM, Pawel Wieczorkiewicz wrote:
>> In the process of creating a final hotpatch module file make sure to
>> strip all transient symbols that have not been caught and removed by
>> create-diff-object processing. For now these are only the hooks
>> kpatch load/unload symbols.
>> 
>> 

snip

>> function create_patch()
>> {
>>     echo "Extracting new and modified ELF sections..."
>> @@ -150,6 +172,7 @@ function create_patch()
>>     NEW_FILES=$(comm -23 <(cd patched/xen && find . -type f -name '*.o' | 
>> sort) <(cd original/xen && find . -type f -name '*.o' | sort))
>>     for i in $NEW_FILES; do
>>         cp "patched/$i" "output/$i"
>> +        strip --strip-unneeded "output/$i"
> 
> This strips debug symbols too which is not necessarily desirable and I think 
> for most software is normally left a high level process (e.g. rpmbuild). Can 
> you make this optional please?
> 

Yes, will do. Thanks for looking.

> Thanks,
> -- 
> Ross Lagerwall

Best Regards,
Pawel Wieczorkiewicz






Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Ralf Herbrich
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel