Re: [Xen-devel] [PATCH 1/2] AMD/IOMMU: Always print IOMMU errors

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Tue, Nov 26, 2019 at 03:01:11PM +0000, Andrew Cooper wrote:
> Unhandled IOMMU errors (i.e. not IO_PAGE_FAULT) should still be printed, and
> not hidden behind iommu=debug.
> 
> While adjusting this, factor out the symbolic name handling to just one
> location exposing its off-by-one nature.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxxx>

LGTM:

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

I wonder however whether XENLOG_G_ERR should be used instead of
XENLOG_ERR in order to rate limit IOMMU faults triggered by guests.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel