Re: [Xen-devel] Ping: [PATCH v2] build: provide option to disambiguate symbol names

[Wei Liu <wl@xxxxxxx>]

On Thu, Nov 28, 2019 at 01:10:05PM +0000, Andrew Cooper wrote:
> On 28/11/2019 10:17, George Dunlap wrote:
> >> On Nov 28, 2019, at 9:55 AM, Jan Beulich <jbeulich@xxxxxxxx> wrote:
> >>>>> Has anyone actually tried building a livepatch with this change in 
> >>>>> place?
> >>>> Actually - what is your concern here? The exact spelling of symbols
> >>>> names should be of no interest to the tool. After all the compiler is
> >>>> free to invent all sorts of names for its local symbols, including
> >>>> the ones we would produce with this change in place. All the tool
> >>>> cares about is that the names be unambiguous. Hence any (theoretical)
> >>>> regression here would be a bug in the tools, which imo is no reason
> >>>> to delay this change any further. (Granted I should have got to it
> >>>> earlier, but it had been continuing to get deferred.)
> >>> This might all be true (theoretically).
> >>>
> >>> The livepatch build tools are fragile and very sensitive to how the
> >>> object files are laid out.  There is a very real risk that this change
> >>> accidentally breaks livepatching totally, even on GCC builds.
> >>>
> >>> Were this to happen, it would be yet another 4.13 regression.
> >> It's perhaps a matter of perception, but I'd still call this a
> >> live patching tools bug then, not a 4.13 regression.
> > After the discussion yesterday, I was thinking a bit more about this, and 
> > I’m not happy with the principle Andy seems to be operating on,
> 
> I'm sorry that you feel that way.
> 
> > that it’s reasonable to completely block a bug-fixing patch to Xen, forcing 
> > a work-around to be used in a release, because it has unknown effects on 
> > livepatching.
> 
> This is not a fair characterisation of what is going on here.  Ignore
> the specifics of this patch - they are not relevant to my objection.
> 
> As a maintainer, it is my responsibility to ensure that crap doesn't get
> committed.
> 

It is fine to have differing opinions; it is not fine to make an
emotionally charged comment like this. It serves no-one's interest.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel