Re: [Xen-devel] [PATCH-for-4.13 v4] Rationalize max_grant_frames and max_maptrack_frames handling

[Jan Beulich <jbeulich@xxxxxxxx>]

On 28.11.2019 17:42, Ian Jackson wrote:
> Jan Beulich writes ("Re: [PATCH-for-4.13 v4] Rationalize max_grant_frames and 
> max_maptrack_frames handling"):
>> On 28.11.2019 14:58, Paul Durrant wrote:
>>>      uint32_t max_vcpus;
>>>      uint32_t max_evtchn_port;
>>> -    uint32_t max_grant_frames;
>>> -    uint32_t max_maptrack_frames;
>>> +    int32_t max_grant_frames;
>>> +    int32_t max_maptrack_frames;
>>
>> While this may want backporting aiui, we need to be a little
>> careful with the interface change here.
> 
> A note here in a list discussion, or even in a commit message, is
> perhaps not going to be very effective to deal with this.
> 
> How bad would it be to change the names as well as the types ?

Hmm, not sure - on one hand this would flag the issue to people
consuming the interface. Otoh it wouldn't help people using
derived header files (they'd notice far later), and causing
breakage like this in stable trees does't look very friendly
either.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel