Re: [Xen-devel] [PATCH] tools/arm: include xen-tools/libs.h from libxl_arm_acpi.c

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Thu, 28 Nov 2019, Wei Liu wrote:
> On Thu, Nov 28, 2019 at 11:30:34AM +0100, Jürgen Groß wrote:
> > On 28.11.19 11:15, Wei Liu wrote:
> > > On Wed, Nov 27, 2019 at 06:24:58PM -0800, Stefano Stabellini wrote:
> > > > libxl_arm_acpi.c is using BUILD_BUG_ON but it is not including
> > > > xen-tools/libs.h that defines it.
> > > > 
> > > > Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
> > > 
> > > Acked-by: Wei Liu <wl@xxxxxxx>
> > > 
> > > Juergen, this is a trivial patch. I think it can go in 4.13.
> > 
> > Why is this patch needed?
> > 
> > tools/libxl/libxl_arm_acpi.c includes libxl_arm.h, which includes
> > libxl_internal.h, which includes xen-tools/libs.h.
> 
> Oh I missed that.
> 
> In that case I don't think this patch is required for 4.13.
> 
> Stefano, did you see a build error or something?
> 

Hi Wei, and Jurgen,

Thanks for the review and also for probably catching a mistake in the
patch.

Yes, this patch fixes a build error with the latest Yocto and gcc 9:

| libxl_arm_acpi.c: In function 'make_acpi_rsdp':
| libxl_arm_acpi.c:193:5: error: implicit declaration of function 
'BUILD_BUG_ON' [-Werror=implicit-function-declaration]
|   193 |     BUILD_BUG_ON(sizeof(ACPI_OEM_ID) != sizeof(rsdp->oem_id));
|       |     ^~~~~~~~~~~~

but the error was based on an older Xen tree based on 4.11, which
doesn't have an include of xen-tools/libs.h in libxl_internal.h. So, I
think Juergen is right that this should not be needed upstream.

I didn't actually have a repro (the issue was reported to me by somebody
else), so before I sent the patch to xen-devel I manually check the code
but couldn't actually try a build. And I didn't notice the include
xen-tools/libs.h in libxl_internal.h. Sorry about that.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel