Re: [Xen-devel] [PATCH-for-4.13 v5] Rationalize max_grant_frames and max_maptrack_frames handling

[Jan Beulich <jbeulich@xxxxxxxx>]

On 28.11.2019 17:52, Paul Durrant wrote:
> --- a/xen/common/grant_table.c
> +++ b/xen/common/grant_table.c
> @@ -84,11 +84,40 @@ struct grant_table {
>      struct grant_table_arch arch;
>  };
>  
> +static int parse_gnttab_limit(const char *param, const char *arg,
> +                              unsigned int *valp)
> +{
> +    const char *e;
> +    unsigned long val;
> +
> +    val = simple_strtoul(arg, &e, 0);
> +    if ( *e )
> +        return -EINVAL;
> +
> +    if ( val > INT_MAX )
> +        return -ERANGE;
> +
> +    return 0;
> +}

*valp doesn't get written to anymore. With this fixed (and no new
issues introduced ;-) ) hypervisor side
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

As an additional remark (not for this patch) - the original wrong
use of __init in v4 could have been replaced by __cold. But I
guess we may want to consider adding such in a wider fashion.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel