[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH-for-4.13 v5] Rationalize max_grant_frames and max_maptrack_frames handling
> -----Original Message----- > From: Ian Jackson <ian.jackson@xxxxxxxxxx> > Sent: 29 November 2019 16:08 > To: Durrant, Paul <pdurrant@xxxxxxxxxx> > Cc: Wei Liu <wl@xxxxxxx>; Anthony Perard <anthony.perard@xxxxxxxxxx>; xen- > devel@xxxxxxxxxxxxxxxxxxxx; George Dunlap <George.Dunlap@xxxxxxxxxx>; > Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>; Jan Beulich > <jbeulich@xxxxxxxx>; Julien Grall <julien@xxxxxxx>; Konrad Rzeszutek Wilk > <konrad.wilk@xxxxxxxxxx>; Stefano Stabellini <sstabellini@xxxxxxxxxx>; > Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>; Volodymyr > Babchuk <Volodymyr_Babchuk@xxxxxxxx>; Roger Pau Monne > <roger.pau@xxxxxxxxxx> > Subject: RE: [PATCH-for-4.13 v5] Rationalize max_grant_frames and > max_maptrack_frames handling > > Durrant, Paul writes ("RE: [PATCH-for-4.13 v5] Rationalize > max_grant_frames and max_maptrack_frames handling"): > > > -----Original Message----- > > > From: Ian Jackson <ian.jackson@xxxxxxxxxx> > ... > > > Is there some reason we wouldn't use ~0 to mean default ? > > > > > > In the tools area we normally spell this as > > > ~(some appropriate type)0 > > > to make sure it has the right width. But if we know the type and it > > > is of fixed length, as here, 0xffffffffu is OK too. > > > > > > > The type change here makes me feel a bit uncomfortable, though in > > > > practice it may not matter. I don't see anyone would specify a value > > > > that would become negative when cast from uint32 to integer. > > > > > > The problem with the type change is that in principle we have to audit > > > all the places the variables are used. > > > > Can a toolstack maintainer please come up with a concrete suggestion as > to what the patch should do then? It's now at v6 and time is short. > > I think our proposal is to drop the type change, continue to use > uint32_t everwhere for these values, and specify the "use default" > value to be all-bits-set. > Where? Everywhere or just in buildinfo? The switch from uint32_t to int32_t in the domctl does not, of course, change the width at all. Paul _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |