Re: [Xen-devel] [PATCH for-4.13] x86: re-order clang no integrated assembler tests

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Mon, Dec 02, 2019 at 11:31:55AM +0000, Andrew Cooper wrote:
> On 02/12/2019 11:29, Roger Pau Monne wrote:
> > The tests to check whether the integrated assembler is capable of
> > building Xen should be performed before testing any assembler
> > features, or else the feature specific tests would be stale if the
> > integrated assembler is disabled afterwards.
> >
> > Fixes: ef286f67787a ('x86: move and fix clang .skip check')
> > Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > Reported-by: Doug Goldstein <cardoe@xxxxxxxxxx>
> > signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > ---
> > Cc: Juergen Gross <jgross@xxxxxxxx>
> 
> Why 4.13?  They are only in 4.14 AFAICT

Oh sorry, I somehow assumed those ended up in 4.13.

> As for the change, looks plausible.  I'll throw it through CI.

I've got one already, which looks good (still in progress, but some
clang tests passed):

https://gitlab.com/xen-project/people/royger/xen/pipelines/99932608

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel