Re: [Xen-devel] [PATCH v5 4/8] x86: introduce hypervisor framework

[Wei Liu <wl@xxxxxxx>]

On Tue, Dec 03, 2019 at 03:49:33PM +0100, Jan Beulich wrote:
> On 30.11.2019 12:57, Wei Liu wrote:
> > We will soon implement Hyper-V support for Xen. Add a framework for
> > that.
> > 
> > This requires moving some of the hypervisor_* functions from xen.h to
> > hypervisor.h.
> > 
> > Signed-off-by: Wei Liu <liuwe@xxxxxxxxxxxxx>
> 
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
[...]
> > +#include <asm/guest/hypervisor.h>
> > +
> > +static const struct hypervisor_ops __read_mostly *ops;
> 
> The __read_mostly is misplaced - it's an attribute of the variable,
> not its type, and hence belongs after the * . It just so happens
> that the compiler is (still) relatively relaxed in what it accepts,
> but I think at least the gcc manual has a warning towards future
> more strict behavior.

Fixed.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel