Re: [Xen-devel] [PATCH] xen/arm: Basic support for sunxi/sun50i h6 platform.

[Andre Przywara <andre.przywara@xxxxxxx>]

On Tue, 3 Dec 2019 16:52:45 +0000
Julien Grall <julien@xxxxxxx> wrote:

Hi,

> On 03/12/2019 14:38, Andre Przywara wrote:
> > On Tue, 3 Dec 2019 11:39:58 +0000
> > Julien Grall <julien@xxxxxxx> wrote:
> > 
> > Hi,
> >   
> >> (+Andre)
> >>
> >> Hi,
> >>
> >> @Andre, IIRC you originally added the support for sunxi in Xen. Could
> >> you have a look at this patch?  
> > 
> > Looks alright, and indeed the H6 needs it. Even though Allwinner totally 
> > re-arranged the memory map, they missed the opportunity to put each device 
> > at least in their own 4K page.
> > 
> > Reviewed-by: Andre Przywara <andre.przywara@xxxxxxx>  
> 
> Thank you for the review!
> 
> > 
> > If you can wait till this evening, I can even test it.  
> 
> I can wait until tomorrow before comitting the patch.

I booted Xen 4.12.1 to the Dom0 prompt on the Pine H64, and saw all the serial 
devices in /sys/firmware/devicetree/base/soc. Then I applied the patch, and the 
serial devices were gone. And yes, all the four main serial ports share one 4K 
page on the H6.

Tested-by: Andre Przywara <andre.przywara@xxxxxxx>

Cheers,
Andre.

> > It's actually a shame that we need this enumeration, when all we are after 
> > is an answer to the question: Does a device used by Xen share a 4K page 
> > with a device handed off to Dom0? It sounds   
> like a nice rainy afternoon exercise to scan the DT to find those 
> devices automatically and mask them (on the A64 for instance UART4 is on 
> a different page).
> 
> I agree and I think we discussed about it before :). I would welcome 
> such improvement in Xen, this would actually allow us to drop sunxi.c 
> completely.
> 
> Cheers,
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel