Re: [Xen-devel] [PATCH v2 1/4] x86/ioapic: only use dest32 with x2apic and interrupt remapping enabled

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Tue, Dec 03, 2019 at 04:11:07PM +0100, Jan Beulich wrote:
> On 29.11.2019 12:28, Roger Pau Monne wrote:
> > --- a/xen/arch/x86/io_apic.c
> > +++ b/xen/arch/x86/io_apic.c
> > @@ -562,7 +562,7 @@ set_ioapic_affinity_irq(struct irq_desc *desc, const 
> > cpumask_t *mask)
> >  
> >      dest = set_desc_affinity(desc, mask);
> >      if (dest != BAD_APICID) {
> > -        if ( !x2apic_enabled )
> > +        if ( !iommu_intremap )
> 
> To match description as well as the other changes done, doesn't
> this need to be "!x2apic_enabled || !iommu_intremap"?

Yes, in fact I already had this change on my local branch, not sure
why it didn't end up in the patch I sent.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel