Re: [Xen-devel] [PATCH 3/4] x86/svm: Clean up intinfo_t variables

[Jan Beulich <jbeulich@xxxxxxxx>]

On 04.12.2019 20:38, Andrew Cooper wrote:
> On 04/12/2019 09:43, Andrew Cooper wrote:
>> @@ -420,10 +420,10 @@ struct vmcb_struct {
>>      u64 exitcode;               /* offset 0x70 */
>>      u64 exitinfo1;              /* offset 0x78 */
>>      u64 exitinfo2;              /* offset 0x80 */
>> -    eventinj_t  exitintinfo;    /* offset 0x88 */
>> +    intinfo_t exitintinfo;      /* offset 0x88 */
>>      u64 _np_enable;             /* offset 0x90 - cleanbit 4 */
>>      u64 res08[2];
>> -    eventinj_t  eventinj;       /* offset 0xA8 */
>> +    intinfo_t eventinj;         /* offset 0xA8 */
>>      u64 _h_cr3;                 /* offset 0xB0 - cleanbit 4 */
>>      virt_ext_t virt_ext;        /* offset 0xB8 */
>>      vmcbcleanbits_t cleanbits;  /* offset 0xC0 */
> 
> On second thoughts, I'm considering using this opportunity to switch to
> exit_int_info and event_inj.
> 
> There are a lot of exit-prefixed names which are easy to confuse at a
> glance.

Fine with me, my R-b stands with this extra purely mechanical
adjustment.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel