Re: [Xen-devel] [PATCH v5 1/2] xenbus/backend: Add memory pressure handler callback

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Tue, Dec 10, 2019 at 11:16:35AM +0100, Roger Pau Monné wrote:
> On Tue, Dec 10, 2019 at 08:06:27AM +0000, SeongJae Park wrote:
> > diff --git a/include/xen/xenbus.h b/include/xen/xenbus.h
> > index 869c816d5f8c..cdb075e4182f 100644
> > --- a/include/xen/xenbus.h
> > +++ b/include/xen/xenbus.h
> > @@ -104,6 +104,7 @@ struct xenbus_driver {
> >     struct device_driver driver;
> >     int (*read_otherend_details)(struct xenbus_device *dev);
> >     int (*is_ready)(struct xenbus_device *dev);
> > +   unsigned (*reclaim)(struct xenbus_device *dev);
> 
> ... hence I wonder why it's returning an unsigned when it's just
> ignored.
> 
> IMO it should return an int to signal errors, and the return should be
> ignored.

Meant to write 'shouldn't be ignored' sorry.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel