[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen/blkfront: Adjust indentation in xlvbd_alloc_gendisk



On Tue, Dec 10, 2019 at 08:15:22AM +0100, Jürgen Groß wrote:
> On 09.12.19 21:14, Nathan Chancellor wrote:
> > Clang warns:
> > 
> > ../drivers/block/xen-blkfront.c:1117:4: warning: misleading indentation;
> > statement is not part of the previous 'if' [-Wmisleading-indentation]
> >                  nr_parts = PARTS_PER_DISK;
> >                  ^
> > ../drivers/block/xen-blkfront.c:1115:3: note: previous statement is here
> >                  if (err)
> >                  ^
> > 
> > This is because there is a space at the beginning of this line; remove
> > it so that the indentation is consistent according to the Linux kernel
> > coding style and clang no longer warns.
> > 
> > While we are here, the previous line has some trailing whitespace; clean
> > that up as well.
> > 
> > Fixes: c80a420995e7 ("xen-blkfront: handle Xen major numbers other than 
> > XENVBD")
> > Link: https://github.com/ClangBuiltLinux/linux/issues/791
> > Signed-off-by: Nathan Chancellor <natechancellor@xxxxxxxxx>
> 
> Reviewed-by: Juergen Gross <jgross@xxxxxxxx>

Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.