Re: [Xen-devel] [XEN PATCH 6/8] xen: Move CONFIG_INDIRECT_THUNK to Kconfig

[Jan Beulich <jbeulich@xxxxxxxx>]

On 13.12.2019 13:18, Anthony PERARD wrote:
> On Fri, Dec 13, 2019 at 12:13:53PM +0100, Jan Beulich wrote:
>> On 12.12.2019 19:27, Anthony PERARD wrote:
>>> --- a/xen/arch/x86/Kconfig
>>> +++ b/xen/arch/x86/Kconfig
>>> @@ -32,6 +32,9 @@ config ARCH_DEFCONFIG
>>>     string
>>>     default "arch/x86/configs/x86_64_defconfig"
>>>  
>>> +config INDIRECT_THUNK
>>> +   def_bool $(cc-option,-mindirect-branch-register)
>>
>> I'm not happy to see constructs like this appear. They leave a
>> "# CONFIG_... is not defined" in .config for no reason when
>> the expression evaluates to n.
> 
> For some reason, this doesn't happen. If $(CC) doesn't understand the
> option, the CONFIG_ doesn't appear at all in .config.

Oh, then all is fine here. I guess they made this work more nicely
in recent Kconfig - my comment above was based on observations in
the past.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel