Re: [Xen-devel] [XEN PATCH 7/8] xen: Use $(CONFIG_CC_IS_CLANG) instead of $(clang) in Makefile

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Thu, Dec 12, 2019 at 07:00:35PM +0000, Andrew Cooper wrote:
> On 12/12/2019 18:27, Anthony PERARD wrote:
> > Kconfig can check if $(CC) is clang or not, if it is
> > CONFIG_CC_IS_CLANG will be set.
> >
> > With that patch, the hypervisor can be built using clang by running
> > `make CC=clang CXX=clang++` without needed to provide an extra clang
> > parameter.
> >
> > `make clang=y` still works as Config.mk will set CC and CXX.
> >
> > Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> 
> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> 
> This is a massive improvement on the status quo.
> 
> Do we perhaps want to tweak the relevant CI scripts and other build
> instructions now that clang=y is obsolete?

No, clang=y isn't obsolete yet. We need to change the tools side as well,
there's a few $(clang) in there. So we need one more patch to remove
them.

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel