Re: [Xen-devel] [XEN PATCH 2/8] Config.mk: Remove stray comment

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Thu, Dec 12, 2019 at 06:32:27PM +0000, Andrew Cooper wrote:
> On 12/12/2019 18:27, Anthony PERARD wrote:
> > This comment isn't about CONFIG_TESTS, but about SEABIOS_DIR that has
> > been removed.
> >
> > Originally, the comment was added by 5f82d0858de1 ("tools: support
> > SeaBIOS. Use by default when upstream qemu is configured."), then
> > later the SEABIOS_DIR was removed by 14ee3c05f3ef ("Clone and build
> > Seabios by default") but that comment about the pain was left behind.
> > The commit that made CONFIG_TESTS painful was 85896a7c4dc7 ("build:
> > add autoconf to replace custom checks in tools/check").
> >
> > Let the comment rest, event if CONFIG_TESTS=y can be painful. It's
> > enabled by default anyway and doesn't cause pain for most
> > configuration.
> 
> Do you mean "rest, even if"?  Even if so, I'm afraid I still can't parse
> this paragraph.

That last paragraph could be remove I think. It is mostly prose which
doesn't add much information. Some people may understand the reference.

When writing that last paragraph, I had that in mind:
https://lists.xenproject.org/archives/html/xen-devel/2019-11/msg01410.html

I though that was amusing, the way the comment was left behind and
started to be understood as a comment for something else.

:-)

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel